[ZEPPELIN-6387] Fix WebSocket reconnection not reloading note in Angular UI#5129
Merged
tbonelee merged 3 commits intoapache:masterfrom Apr 5, 2026
Merged
[ZEPPELIN-6387] Fix WebSocket reconnection not reloading note in Angular UI#5129tbonelee merged 3 commits intoapache:masterfrom
tbonelee merged 3 commits intoapache:masterfrom
Conversation
seung-00
approved these changes
Feb 6, 2026
Contributor
seung-00
left a comment
seung-00
left a comment
There was a problem hiding this comment.
Tested locally and looks fine to me.
| if (connected) { | ||
| const { noteId, revisionId } = this.activatedRoute.snapshot.params; | ||
| if (!noteId) { | ||
| throw new Error('Query parameter `noteId` is required.'); |
Contributor
There was a problem hiding this comment.
nit: noteId looks like a path parameter.
seung-00
approved these changes
Feb 6, 2026
Contributor
Author
|
@jongyoul @ParkGyeongTae Could you help review this? |
jongyoul
approved these changes
Apr 5, 2026
tbonelee
added a commit
that referenced
this pull request
Apr 5, 2026
…lar UI ### What is this PR for? Fixes an issue where WebSocket reconnection in the new Angular UI (zeppelin-web-angular) does not reload the current note, causing "Note is null" errors when attempting to run paragraphs after reconnection. ### What type of PR is it? Bug Fix ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-6387 ### How should this be tested? 1. Open any notebook in the new Angular UI. 2. Trigger a WebSocket timeout by switching to another browser tab or window and leaving the Zeppelin tab in the background for a few minutes. - Even without interacting with the browser, you can confirm that the WebSocket has reconnected by checking the server logs. 3. Allow the system to automatically reconnect. 4. Try running any paragraph → It should fail before this PR and succeed after applying this PR. ### Questions: * Does the license files need to update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Closes #5129 from tbonelee/websocket-reconnection. Signed-off-by: ChanHo Lee <chanholee@apache.org> (cherry picked from commit 705110a) Signed-off-by: ChanHo Lee <chanholee@apache.org>
Contributor
Author
|
Thanks! Merged into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Fixes an issue where WebSocket reconnection in the new Angular UI (zeppelin-web-angular) does not reload the current note, causing "Note is null" errors when attempting to run paragraphs after reconnection.
What type of PR is it?
Bug Fix
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-6387
How should this be tested?
Questions: